Change in ovirt-engine[master]: core: RegisterVdsQuery final lock

Code Review gerrit at ovirt.org
Fri Jan 6 14:45:46 UTC 2017


>From Martin Peřina <mperina at redhat.com>:

Martin Peřina has submitted this change and it was merged.

Change subject: core: RegisterVdsQuery final lock
......................................................................


core: RegisterVdsQuery final lock

Made the lock field final. As it contains no actual data, changing the
lock object would server no real purpose, and may introduce
hard-to-discover bugs where one instance is synchronized on the old lock
object and one on the new lock object. Making the member final adds
another compile-time safe guard against someone doing this by mistake in
the future.

Change-Id: I173963ec222dae41b94109badb8533b3af3aa51f
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/RegisterVdsQuery.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Ravi Nori: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/69689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I173963ec222dae41b94109badb8533b3af3aa51f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list