Change in ovirt-engine[master]: backend: fix logging of disks with illegal Pass Discard

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: backend: fix logging of disks with illegal Pass Discard
......................................................................


backend: fix logging of disks with illegal Pass Discard

Previously, when adding a cloned vm from a template, if at least one of
the target vm's disks had an illegal Pass Discard value, the wrong
disks' ids were logged (the source disks' ids instead of the target
ones).
This patch simplifies the way we log these disks by moving the log
handling to BlockStorageDiscardFunctionalityHelper and fixes this bug,
so that now the right ids are logged.

Change-Id: I566b36d3b7c25c4b8badfa59a9113fd3885eac4d
Bug-Url: https://bugzilla.redhat.com/1410017
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/DiskHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/utils/BlockStorageDiscardFunctionalityHelper.java
4 files changed, 32 insertions(+), 35 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/69545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I566b36d3b7c25c4b8badfa59a9113fd3885eac4d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>