Change in ovirt-engine[master]: aaa: Session expired message shown on SSO login page after s...

Code Review gerrit at ovirt.org
Fri Jan 13 06:57:51 UTC 2017


>From Martin Peřina <mperina at redhat.com>:

Martin Peřina has submitted this change and it was merged.

Change subject: aaa: Session expired message shown on SSO login page after session expiration
......................................................................


aaa: Session expired message shown on SSO login page after session expiration

When the user leaves the login page open
for a period of time the session expires
and the associated SsoSession is cleaned
up. Entering user credentials and attempting
to login shows "Session expired please try
again" message.

The SsoSession object should be saved in
SsoContext with an identification token as
key which is also available on login page.
When user tried to login if the session has
expired the SsoSession can be retrieved from
the SsoContext using the session id token.

Change-Id: Idc33455751ea25e8ac77b5549e503d15b7a06960
Bug-Url: https://bugzilla.redhat.com/1411416
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveAuthServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoContext.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoSession.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java
M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp
5 files changed, 71 insertions(+), 3 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Ravi Nori: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/69872
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idc33455751ea25e8ac77b5549e503d15b7a06960
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list