Change in ovirt-engine[master]: webadmin: Tag improvements

Code Review gerrit at ovirt.org
Fri Jan 13 13:07:35 UTC 2017


>From Alexander Wels <awels at redhat.com>:

Alexander Wels has submitted this change and it was merged.

Change subject: webadmin: Tag improvements
......................................................................


webadmin: Tag improvements

- Added UI plugin event that is fired when a tag is activated
  or deactivated. The event object will contain the number of
  current activated tags.
- Fixed issue with search string not being cleared after
  de-activating a tag.
- Fixed issue where PluginModel were being marked unavailable
  due to all ListModels in CommonModel being marked unavailable
  even though PluginModels don't care about that field as the
  dynamic tab presenters take care of showing/hiding the tab.
- Introduced new ui plugin API to retrieve the root tag node
  including all the children.

Change-Id: Ie90a623cf3378bf39557223d19d305bff3faae91
Bug-Url: https://bugzilla.redhat.com/1367072
Signed-off-by: Alexander Wels <awels at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/plugin/PluginModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java
M frontend/webadmin/modules/webadmin/exclude-filters.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginEventHandler.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/TagObject.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/TagModelProvider.java
9 files changed, 139 insertions(+), 3 deletions(-)

Approvals:
  Alexander Wels: Verified
  Jenkins CI: Passed CI tests
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/68660
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie90a623cf3378bf39557223d19d305bff3faae91
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list