Change in ovirt-engine[ovirt-engine-4.1]: core: better support in the monitoring for auto start of vms...

Code Review gerrit at ovirt.org
Sun Jan 15 14:03:19 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: better support in the monitoring for auto start of vms with lease
......................................................................


core: better support in the monitoring for auto start of vms with lease

Prevent the VM from switching to Down state upon failure to start on a host
while being in Unknown state on another host:
1. We do not change the status and run_on_vds fields of the VM on run VM.
2. Clear the async running VM operation before auto start attempt to avoid
errors of type 'VM is during initiating'.
3. Clear the async running VM when a VM is restored from Unknown status
(but not when it goes to WaitForLaunch or MigratingTo statuses that do
not necessarily mean that the VM is actually running).

Change-Id: Icca6920dce600959045d8885404a0de056b88c8f
Bug-Url: https://bugzilla.redhat.com/1317429
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVmVDSCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
5 files changed, 34 insertions(+), 6 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/69683
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icca6920dce600959045d8885404a0de056b88c8f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list