Change in ovirt-engine[master]: core: RunVmCommand - Emulated Machine conforms the CCV

Code Review gerrit at ovirt.org
Sun Jan 15 16:16:35 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: RunVmCommand - Emulated Machine conforms the CCV
......................................................................


core: RunVmCommand - Emulated Machine conforms the CCV

RunVmCommand selects 'default' Emulated Machine corresponding
to the Custom Compatibility Version, if set.

The selection is based on best-match heuristics to match the platform
(recent default cluster emulated machine vs. vdc_options.ClusterEmulatedMachine).

The issue was originaly identified for preview of snapshot with memory
originating in previous cluster version (before cluster upgrade).
In that flow, the CCV is set for the previewed snapshot to
retain VM configuration, including the emulated machine.

Change-Id: I029441010cfd4c3b47fbe687c96748aced565bae
Bug-Url: https://bugzilla.redhat.com/1364456
Signed-off-by: Marek Libra <mlibra at redhat.com>
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
2 files changed, 61 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/69915
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I029441010cfd4c3b47fbe687c96748aced565bae
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list