Change in ovirt-engine[master]: core: VmInterfaceManagerTest redundant stubbing

Code Review gerrit at ovirt.org
Mon Jan 16 09:37:55 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: VmInterfaceManagerTest redundant stubbing
......................................................................


core: VmInterfaceManagerTest redundant stubbing

Remove redundant [unused] stubbing. This unused stubbing has no effect
on the test, and just confuses the reader.
More importantly, newer Mockito versions are stricter by default, and
this will actually fail the test.

Change-Id: Iccee39f2ee3e18d487f0236005db6fe4486cebc5
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java
1 file changed, 0 insertions(+), 20 deletions(-)

Approvals:
  Martin Mucha: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/70216
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iccee39f2ee3e18d487f0236005db6fe4486cebc5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list