Change in ovirt-engine[master]: core: HostSetupNetworksValidatorTest redundant stubbing

Code Review gerrit at ovirt.org
Mon Jan 16 21:17:47 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: HostSetupNetworksValidatorTest redundant stubbing
......................................................................


core: HostSetupNetworksValidatorTest redundant stubbing

Remove redundant [unused] stubbing. This unused stubbing has no effect
on the test, and just confuses the reader.
More importantly, newer Mockito versions are stricter by default, and
this will actually fail the test.

Change-Id: I198f11f6d9218e63085301fcfa501f5dc7c463ef
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
1 file changed, 0 insertions(+), 9 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/70220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I198f11f6d9218e63085301fcfa501f5dc7c463ef
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list