Change in ovirt-engine[master]: core : Search based on negated fields with null values doesn...

Code Review gerrit at ovirt.org
Tue Jan 17 14:19:31 UTC 2017


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: core : Search based on negated fields with null values doesn't work properly
......................................................................


core : Search based on negated fields with null values doesn't work properly

Search Queries with null values in columns
do not work properly. Need to check for IS
Null for the nullable column.

Change-Id: Iae05bb8307f668c01242ff609d330195d5b9a22d
Bug-Url: https://bugzilla.redhat.com/1252906
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java
2 files changed, 31 insertions(+), 25 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Ravi Nori: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/69945
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iae05bb8307f668c01242ff609d330195d5b9a22d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list