Change in ovirt-engine[ovirt-engine-4.1]: engine: order nics by their number in the name

Code Review gerrit at ovirt.org
Tue Jan 17 15:11:14 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: engine: order nics by their number in the name
......................................................................


engine: order nics by their number in the name

'nic2' should come before 'nic10'.

Change-Id: I71812cc849be2ec3df1c27af68651226d1c218d1
Bug-Url: https://bugzilla.redhat.com/1315878
Signed-off-by: Yevgeny Zaspitsky <yzaspits at redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/common/comparator/NumericSuffixNameableComparator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ReorderVmNicsCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/common/comparator/NumericSuffixNameableComparatorTest.java
3 files changed, 119 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved
  Yevgeny Zaspitsky: Verified



-- 
To view, visit https://gerrit.ovirt.org/70646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I71812cc849be2ec3df1c27af68651226d1c218d1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list