Change in ovirt-engine[ovirt-engine-4.1]: core: Check storage domain before executing commands with VM...

Code Review gerrit at ovirt.org
Tue Jan 17 21:02:37 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Check storage domain before executing commands with VM leases
......................................................................


core: Check storage domain before executing commands with VM leases

Before creating or updating a VM with a VM lease, validate that the
selected storage domain for the lease exists, active and is a part of the
storage pool the VM belongs to, if those terms are not met the operation
will fail.
In case of importing a VM with a VM lease, if the domain does not meet the
criteria the VM will be imported without a VM lease and an audit log
warning will be issued.

Bug-Url: https://bugzilla.redhat.com/1413961
Change-Id: Id448f6e86d635ffe1743ed8e542d631d8ea2fe5a
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
6 files changed, 35 insertions(+), 5 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/70701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id448f6e86d635ffe1743ed8e542d631d8ea2fe5a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>


More information about the Engine-commits mailing list