Change in ovirt-engine[ovirt-engine-4.1]: engine: for bonds mode=4 setting default xmit_hash_policy

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: engine: for bonds mode=4 setting default xmit_hash_policy
......................................................................


engine: for bonds mode=4 setting default xmit_hash_policy

On creating new bonds with mode=4 (Dynamic link aggregation (802.3ad))
trough the web UI, the  xmit_hash_policy is set explicitly to the
numeric value 2 (layer2+3).

The value is set numerically to be consistent to vdsm, which reports
values of bonding options numerically, instead of textual.

Already available bonds with mode=4 without xmit_hash_policy=2 are not
changed and reported as "custom" options in the web UI.

The previously used default xmit_hash_policy=layer2 uses just
hardware MAC addresses of source and destination to decide which slave
of the bond is used to transmit.
The new default xmit_hash_policy=layer2+3 additionally considers the
layer 3 addresses, if available, and is still 802.3ad compliant.
This policy is intended to provide a more balanced distribution of
traffic than layer2 alone, especially in environments where a layer3
routing is required to reach most destinations.

Change-Id: I5b6cb2dfe8f0b60a1e81aa4832bc8c10672f6bb8
Bug-Url: https://bugzilla.redhat.com/1397490
Signed-off-by: Dominik Holler <dholler at redhat.com>
(cherry picked from commit fa2421f05a318c7667838280c5e29d39b823380d)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/BondMode.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
4 files changed, 19 insertions(+), 2 deletions(-)

Approvals:
  Marcin Mirecki: Looks good to me, but someone else must approve
  Dominik Holler: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/70723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5b6cb2dfe8f0b60a1e81aa4832bc8c10672f6bb8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>