Change in ovirt-engine[master]: core: GlusterSnapshotSyncJobTest#getSnapshotVDSReturnVal

Code Review gerrit at ovirt.org
Thu Jan 19 21:08:20 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: GlusterSnapshotSyncJobTest#getSnapshotVDSReturnVal
......................................................................


core: GlusterSnapshotSyncJobTest#getSnapshotVDSReturnVal

getSnapshotVDSReturnVal(boolean) is always called with true, making this
argument redundant.

This patch inlines the arguments in order to clean up the code and make
it easier to read.

Change-Id: Ie06fffca79a36e938d635af353d05c2bf39d378c
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJobTest.java
1 file changed, 4 insertions(+), 8 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/70233
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie06fffca79a36e938d635af353d05c2bf39d378c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list