Change in ovirt-engine[ovirt-engine-4.1]: core: UpdateVmTemplate doesn't load disks

Code Review gerrit at ovirt.org
Sun Jan 22 18:21:46 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: UpdateVmTemplate doesn't load disks
......................................................................


core: UpdateVmTemplate doesn't load disks

UpdateVmTemplate command doesn't load disks of old template.

This patch fixes problem of failing validation caused by
`vmTemplateHandler.isUpdateValid()` returning false since
VmTemplate#actualDiskSize seemed to be changed (greater than zero for
old template with loaded disks and zero for new template) and missing
annotation allowing the change.

Change-Id: Ib1f32fe2fc61a425313a331849854ae9feaecf64
Bug-Url: https://bugzilla.redhat.com/1409579
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/70784
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1f32fe2fc61a425313a331849854ae9feaecf64
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list