Change in ovirt-engine[master]: core: UpdateVmCommandTest#mockDiskDaoGetAllForVm signature

Code Review gerrit at ovirt.org
Sun Jan 22 20:48:32 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: UpdateVmCommandTest#mockDiskDaoGetAllForVm signature
......................................................................


core: UpdateVmCommandTest#mockDiskDaoGetAllForVm signature

The onlyPluggedDisks argument is always passed as true, so there's no
real value in having it as an argument at all.
This patch inlines this useless parameter and replaces it with a literal
of true.

Change-Id: I0a0911f43dc68f80839f37bbf69316ec56f17089
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/70263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0a0911f43dc68f80839f37bbf69316ec56f17089
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list