Change in ovirt-engine[master]: core: CommonVmPoolCommandTestAbstract size mocking

Code Review gerrit at ovirt.org
Sun Jan 22 20:48:33 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: CommonVmPoolCommandTestAbstract size mocking
......................................................................


core: CommonVmPoolCommandTestAbstract size mocking

As this command uses a validator (which is mocked away in the test) to
check that there's sufficient storage space, there's no need for the
test to explicitly handle it.

This patch removes this redundant mocking.

Change-Id: I12a7fa70a2518f6be408f8e29d0f6a027aeb56dc
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolCommandTestAbstract.java
1 file changed, 8 insertions(+), 18 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/70258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I12a7fa70a2518f6be408f8e29d0f6a027aeb56dc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list