Change in ovirt-engine[master]: core: Don't use anySetOf(Class)

Code Review gerrit at ovirt.org
Mon Jan 23 07:17:34 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Don't use anySetOf(Class)
......................................................................


core: Don't use anySetOf(Class)

Mockito 1.x's anySet() returned a raw Set, which would cause
unchecked assignment warning when it was used in a generic context.
Mockito 2.x fixed this to return a Set<T>, and uses Java 8's
capabilities to infer the generic type. As a result, anySetOf(Class)
was deprecated, and will be removed in the near future.

This patch removes all usages of anySetOf(Class) and replaces them with
the recommended anySet().

Change-Id: I4fe8615f84a11035a8564ef4b6767bedf2c8cbad
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolCommandTestAbstract.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/aaa/SessionDataContainerTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/GlusterUtilTest.java
3 files changed, 6 insertions(+), 7 deletions(-)

Approvals:
  Ravi Nori: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests
  Moti Asayag: Looks good to me, approved

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/70298
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4fe8615f84a11035a8564ef4b6767bedf2c8cbad
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list