Change in ovirt-engine[master]: setup: let vmconsole proxy be stopped on cleanup

Code Review gerrit at ovirt.org
Mon Jan 30 07:28:10 UTC 2017


>From Sandro Bonazzola <sbonazzo at redhat.com>:

Sandro Bonazzola has submitted this change and it was merged.

Change subject: setup: let vmconsole proxy be stopped on cleanup
......................................................................


setup: let vmconsole proxy be stopped on cleanup

We must make sure that engine-cleanup actually
cleans up the ovirt-vmconsole-proxy.
This means stopping the service, if running.

Change-Id: I5910b214470a69ffd3d2fc5fdc546ec6de32e402
Bug-Url: https://bugzilla.redhat.com/1276670
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/constants.py
M packaging/setup/plugins/ovirt-engine-common/vmconsole_proxy_helper/core.py
A packaging/setup/plugins/ovirt-engine-remove/vmconsole_proxy_helper/__init__.py
A packaging/setup/plugins/ovirt-engine-remove/vmconsole_proxy_helper/misc.py
M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py
5 files changed, 141 insertions(+), 0 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Yedidyah Bar David: Looks good to me, but someone else must approve
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/65968
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5910b214470a69ffd3d2fc5fdc546ec6de32e402
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list