Change in ovirt-engine[master]: core: always compute boot order on run vm

Code Review gerrit at ovirt.org
Mon Jan 30 12:24:01 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: always compute boot order on run vm
......................................................................


core: always compute boot order on run vm

On regular run-VM we used to rely on the boot order that is set on each
device, while on run-once we computed the boot order according to the
given boot sequence (if it is different than the default boot sequence
that is defined for the VM, otherwise it behaved as regular run).

With this patch we always compute the boot order, not only on
run-once flow (on regular run it is done according to the VM's default
boot sequence). That way, we don't rely on the boot order that is set
on each device, so it enables us to remove this field and get rid of
the duplicated data whose management tends to complicate addition,
update and removal of bootable devices.

Change-Id: I20b6ad6c2002a857b073dd81a32be064415fbbcc
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java
2 files changed, 16 insertions(+), 41 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/71333
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I20b6ad6c2002a857b073dd81a32be064415fbbcc
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list