Change in ovirt-engine[master]: core: Check all volumes for their QCOW format.

Code Review gerrit at ovirt.org
Mon Jul 3 12:23:37 UTC 2017


>From Maor Lipchuk <mlipchuk at redhat.com>:

Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/78675 )

Change subject: core: Check all volumes for their QCOW format.
......................................................................


core: Check all volumes for their QCOW format.

Since amend might fail in the middle of an operation, some volumes
might not be amended, therefore the engine should not check only the
active volume but all the disk's QCOW volumes.

Change-Id: I545686ff0b368c6062d392ba24c36e7d14eb24dc
Bug-Url: https://bugzilla.redhat.com/1464766
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AmendImageGroupVolumesCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java
3 files changed, 14 insertions(+), 5 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/78675
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I545686ff0b368c6062d392ba24c36e7d14eb24dc
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list