Change in ovirt-hosted-engine-setup[master]: appliance upgrade: drop root privileges on storage

Code Review gerrit at ovirt.org
Mon Jul 3 13:20:01 UTC 2017


>From Simone Tiraboschi <stirabos at redhat.com>:

Simone Tiraboschi has submitted this change and it was merged. ( https://gerrit.ovirt.org/78852 )

Change subject: appliance upgrade: drop root privileges on storage
......................................................................


appliance upgrade: drop root privileges on storage

accessing the storage with libguestfs fails if the storage
is NFS with root_squash option.
Dropping root privileges for libguestfs operations.
Added exception handling while touching the guestfs related code.

Change-Id: Ifeef9962b4d43039e4886c7f5555d75fe4fdafb6
Bug-Url: https://bugzilla.redhat.com/1466234
Signed-off-by: Sandro Bonazzola <sbonazzo at redhat.com>
---
M src/plugins/gr-he-common/vm/boot_disk.py
1 file changed, 51 insertions(+), 20 deletions(-)

Approvals:
  Simone Tiraboschi: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/78852
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifeef9962b4d43039e4886c7f5555d75fe4fdafb6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde at redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael at rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list