Change in ovirt-engine[master]: core: dal AppErrors.properties removed

Code Review gerrit at ovirt.org
Tue Jul 4 13:32:09 UTC 2017


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged. ( https://gerrit.ovirt.org/76216 )

Change subject: core: dal AppErrors.properties removed
......................................................................


core: dal AppErrors.properties removed

... to simplify translation process.

>From this patch on the property file is copied from 'frontend' project
during the build. 'dependency:copy-dependencies' is not used since 'dal'
project is compiled before project 'frontend' where source property file
is located.

Differences between 'dal' and 'frontend' AppErrors.properties were
manually resolved. The changes in translations should be fixes only.

After this patch is merged, there will be two AppError.properties files:
one for 'userportal' project and one for backend and webadmin located in
'frontend' project.

Change-Id: Ibf0f48419796176e3e8592b08c5faac575774854
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M backend/manager/modules/dal/pom.xml
D backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
D backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/ErrorMessagesTest.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 84 insertions(+), 1,622 deletions(-)

Approvals:
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Vojtech Szocs: Looks good to me, but someone else must approve
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/76216
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf0f48419796176e3e8592b08c5faac575774854
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list