Change in ovirt-engine[master]: backend: improve problematic block domains sync

Code Review gerrit at ovirt.org
Mon Jul 10 08:24:19 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79176 )

Change subject: backend: improve problematic block domains sync
......................................................................


backend: improve problematic block domains sync

When a block storage domain's status is StorageDomainStatus.Inactive but
vdsm reports that it is DomainMonitoringResult.OK, the domain's status
is switched to StorageDomainStatus.Active.

Today, the engine calls SyncLunsInfoForBlockStorageDomain for each such
domain in a new thread using the same host.
This patch improves this behavior by synchronizing all the domains
together using SyncStorageDomainsLuns and thus performing one call to
vdsm (instead one per domain) in one thread.

Change-Id: I1d8ddb18e5b40006c88eb632801920c14045db71
Bug-Url: https://bugzilla.redhat.com/1468974
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxy.java
3 files changed, 7 insertions(+), 17 deletions(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/79176
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1d8ddb18e5b40006c88eb632801920c14045db71
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list