Change in jenkins[master]: cleanup_slave: Fixed the cleanup of docker images

Code Review gerrit at ovirt.org
Tue Jul 11 14:47:23 UTC 2017


>From Barak Korren <bkorren at redhat.com>:

Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/77751 )

Change subject: cleanup_slave: Fixed the cleanup of docker images
......................................................................


cleanup_slave: Fixed the cleanup of docker images

We can't cleanup docker images by image ID as we might remove
'whitelisted' images.
For example, a job that tags the official centos image with custom:tag,
then we'll search for all the images which doesn't belong to the
whitelisted repositories, and remove them (referring them by image id) -
this will cause the whitelisted image to be removed.

The new cleanup, is referring images by it's repository:tag, and will
not remove whitelisted images even if the repository name was retagged
by another image during the run.

Change-Id: I3c780cd5b7bc329e5715a1c7d9340340ac073cac
---
M jobs/confs/shell-scripts/cleanup_slave.sh
1 file changed, 2 insertions(+), 7 deletions(-)

Approvals:
  Barak Korren: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Daniel Belenky: Verified; Ready for merge



-- 
To view, visit https://gerrit.ovirt.org/77751
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3c780cd5b7bc329e5715a1c7d9340340ac073cac
Gerrit-PatchSet: 11
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Daniel Belenky <dbelenky at redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk at redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky at redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi at redhat.com>


More information about the Engine-commits mailing list