Change in ovirt-engine[master]: restapi: support setting empty CCV value for a VM via REST api

Code Review gerrit at ovirt.org
Tue Jul 11 14:52:27 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79223 )

Change subject: restapi: support setting empty CCV value for a VM via REST api
......................................................................


restapi: support setting empty CCV value for a VM via REST api

Trying to set the Custom Compatibility Version of a VM to an empty/null
value via REST api (in order to take the Custom Compatibility Version value
of the Cluster) was not supported/handled.

This patch fixed it, so that for setting the Custom Compatibility Version
of a VM to null, the REST api request body should include:
<vm>
    <custom_compatibility_version/>
</vm>

This will be translated to sending entity.customCompatibilityVersion set
to null as required.

Change-Id: I6cdc527b3fca98e0ee230275563539fd28020966
Bug-Url: https://bugzilla.redhat.com/1464819
Signed-off-by: Sharon Gratch <sgratch at redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Juan Hernandez: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Sharon Gratch: Verified
  Arik Hadas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/79223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6cdc527b3fca98e0ee230275563539fd28020966
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list