Change in ovirt-engine[master]: core: MoveOrCopyDiskCommandTest DiskVmElementDao mocking

Code Review gerrit at ovirt.org
Wed Jul 12 14:54:43 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79272 )

Change subject: core: MoveOrCopyDiskCommandTest DiskVmElementDao mocking
......................................................................


core: MoveOrCopyDiskCommandTest DiskVmElementDao mocking

Removed mocking of DiskVmElementDao, which is not used directly by
the command, and replaced it with mocking of the validator that uses
it.

This way, the MoveOrCopyDiskCommandTest only tests the command's
logic, and not the internal workings of the validator.

Change-Id: I3a4618628d1f256a3a2b643ce190f225f9cabe6d
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommandTest.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/79272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3a4618628d1f256a3a2b643ce190f225f9cabe6d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list