Change in ovirt-engine[master]: core: setupnetworks for old and new network when updating de...

Code Review gerrit at ovirt.org
Sun Jul 16 15:23:49 UTC 2017


>From Alona Kaplan <alkaplan at redhat.com>:

Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/76928 )

Change subject: core: setupnetworks for old and new network when updating default route
......................................................................


core: setupnetworks for old and new network when updating default route

when default route role is granted to different network, then for new
(gaining new role) and old network (losing current role) must be
called setupnetworks.

Change-Id: Ie0bfb4472847d769857280a41dd6c014dcbc0668
Bug-Url: https://bugzilla.redhat.com/1445171
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageNetworksParametersBuilder.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageNetworksParametersBuilderFactory.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageNetworksParametersBuilderImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManageNetworkClustersCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/PropagateNetworksToClusterHostsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/transformer/NetworkClustersToSetupNetworksParametersTransformer.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/transformer/NetworkClustersToSetupNetworksParametersTransformerFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/transformer/NetworkClustersToSetupNetworksParametersTransformerImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActionType.java
12 files changed, 142 insertions(+), 50 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/76928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0bfb4472847d769857280a41dd6c014dcbc0668
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list