Change in ovirt-engine[master]: webadmin: Fix issue with double call to clearslot

Code Review gerrit at ovirt.org
Tue Jul 18 17:58:36 UTC 2017


>From Alexander Wels <awels at redhat.com>:

Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/79513 )

Change subject: webadmin: Fix issue with double call to clearslot
......................................................................


webadmin: Fix issue with double call to clearslot

- In certain situations calling clearslot in MainContentPresenter
  would cause another call to the same method (from internalHide) which
  could set the parent to null which would then cause an npe when we
  returned to the handling of the original clear slot. This 'fixes'
  the issue by putting a guard around clear slot to not call it while
  we are clearing a slot already.

Change-Id: I78a1ec903dfcd4419ab8eb837f0ce4dc73ed7f3c
Signed-off-by: Alexander Wels <awels at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/MainContentPresenter.java
1 file changed, 42 insertions(+), 36 deletions(-)

Approvals:
  Alexander Wels: Verified
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/79513
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I78a1ec903dfcd4419ab8eb837f0ce4dc73ed7f3c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list