Change in ovirt-engine[master]: core: Added invalidate cache mechanism for domain files refresh

Code Review gerrit at ovirt.org
Wed Jul 19 12:05:02 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79030 )

Change subject: core: Added invalidate cache mechanism for domain files refresh
......................................................................


core: Added invalidate cache mechanism for domain files refresh

Unless force refresh was specified every call to list a domain files was
returning cached results from the DB rather than getting the files list
from the storage, this was changed to invalidate the cache after a
specified number of minutes from the last refresh (default is 1 minute and
can be changed by changing the RepoDomainInvalidateCacheTimeInMinutes
configuration value).

The old mechanism was based on a periodical refresh every 60 minutes
(configurable) regardless of whether there was a request for the files
list, this mechanism was removed.

Change-Id: I8eccea6f440cf0050626f95a1999af912c575287
Bug-Url: https://bugzilla.redhat.com/1414207
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/IsoDomainListSynchronizer.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDaoTest.java
M packaging/dbscripts/repo_files_meta_data_sp.sql
A packaging/dbscripts/upgrade/04_02_0410_remove_auto_repo_refresh_config_value.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
8 files changed, 33 insertions(+), 295 deletions(-)

Approvals:
  Tal Nisan: Verified; Passed CI tests
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/79030
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8eccea6f440cf0050626f95a1999af912c575287
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Shani Leviim <sleviim at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list