Change in otopi[master]: core: Read config files early

Code Review gerrit at ovirt.org
Mon Jul 24 10:32:35 UTC 2017


>From Yedidyah Bar David <didi at redhat.com>:

Yedidyah Bar David has submitted this change and it was merged. ( https://gerrit.ovirt.org/79743 )

Change subject: core: Read config files early
......................................................................


core: Read config files early

It used to be at STAGE_INIT, PRIORITY_HIGH - 10.
A recent patch removed the priority.
So any plugin that happened to setdefault some env key to None,
before otopi ran core/config.py, succeeded. So answer files setting the
default (which is the default for our automatically-generated answer
files, so most automation tools inherited this as well), did not work.

Revert this for now.

Later on, we should move to STAGE_BOOT, but change all plugins that
set CONFIG_FILE_NAME to run before us (CORE_CONFIG_INIT).

Change-Id: Ib3adb0821c9d2702092e1bbd80234309888f2838
Signed-off-by: Yedidyah Bar David <didi at redhat.com>
---
M src/plugins/otopi/core/config.py
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Yedidyah Bar David: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/79743
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3adb0821c9d2702092e1bbd80234309888f2838
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde at redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael at rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list