Change in jenkins[master]: Improve email message from change queue

Code Review gerrit at ovirt.org
Mon Jul 24 11:17:05 UTC 2017


>From Barak Korren <bkorren at redhat.com>:

Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/78491 )

Change subject: Improve email message from change queue
......................................................................


Improve email message from change queue

There are two cases where changes can fail CQ testing but not be the
root cause for failure:
1. Either a change explicitly depends on another change that failed
2. Or a change is based on a failing change and therefore includes the
   failing code or artifacts

The system as it built currently, cannot easily tell these two cases
apart. Therefore, the same email message is sent for both. So far the
message was written in such a way that assumes case #1. With the current
system, however, case #2 is far more likely. This patch attempts to
change the language in the failing email to better indicate this.

This patch also:
* Adds the queue name to the subject of the email messages
* Make email subject lines start with '[CQ]:'
* Include the queue name in the email subject lines

Change-Id: I11a511c8b4cdb5b2838e64cd592e0296b8cae862
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1077
Signed-off-by: Barak Korren <bkorren at redhat.com>
---
M scripts/change_queue/changes/templates/added-email.txt.j2
M scripts/change_queue/changes/templates/failed-email.txt.j2
M scripts/change_queue/changes/templates/rejected-email.txt.j2
M scripts/change_queue/changes/templates/successful-email.txt.j2
4 files changed, 16 insertions(+), 11 deletions(-)

Approvals:
  Barak Korren: Verified; Looks good to me, approved; Ready for merge
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/78491
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I11a511c8b4cdb5b2838e64cd592e0296b8cae862
Gerrit-PatchSet: 9
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk at redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky at redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi at redhat.com>


More information about the Engine-commits mailing list