Change in ovirt-engine[master]: webadmin: resize dashboard on window resize

Code Review gerrit at ovirt.org
Tue Jul 25 16:24:35 UTC 2017


>From Alexander Wels <awels at redhat.com>:

Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/79776 )

Change subject: webadmin: resize dashboard on window resize
......................................................................


webadmin: resize dashboard on window resize

Previously, the dashboard (and other ui plugins) had their
height calculated at iframe load time. However, when a user
resized the window, the iframe height was not recalculated,
often leading to a duplicate vertical scrollbar (one for the
page, one for the iframe.)

Fixed by simply calling the frame resize handler on page
resize as well.

Change-Id: I3af0f64bf4d7013dd3d31f675490368e5bdd7c7c
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/DynamicUrlContentTabView.java
1 file changed, 6 insertions(+), 8 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Verified



-- 
To view, visit https://gerrit.ovirt.org/79776
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3af0f64bf4d7013dd3d31f675490368e5bdd7c7c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list