Change in ovirt-engine[master]: backend: direct LUN should not have a PV ID in the DB

Code Review gerrit at ovirt.org
Sun Jul 30 14:32:40 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79877 )

Change subject: backend: direct LUN should not have a PV ID in the DB
......................................................................


backend: direct LUN should not have a PV ID in the DB

When a lun is used as a part of a storage domain, it contains a PV ID in
the luns table.
However, when it is used as a direct LUN, vdsm doesn't create a PV on it
and thus it shouldn't contain a PV ID in that table.

This patch makes sure that a lun won't have an old PV ID in the DB (the
PV ID of that lun which was previously a part of a storage domain) in
case it is used purely as a direct LUN, and not both as a part of a
storage domain and as a direct LUN.

Change-Id: I427bfae9102e1465d7f00d18bdf9cf9372b6c1a1
Bug-Url: https://bugzilla.redhat.com/1475767
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageHelperBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/LunHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncDirectLunsCommand.java
4 files changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/79877
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I427bfae9102e1465d7f00d18bdf9cf9372b6c1a1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list