Change in ovirt-engine[master]: webadmin: AbstractSubTabPanelPresenter code cleanup

Code Review gerrit at ovirt.org
Mon Jul 31 18:56:45 UTC 2017


>From Vojtech Szocs <vszocs at redhat.com>:

Vojtech Szocs has submitted this change and it was merged. ( https://gerrit.ovirt.org/79912 )

Change subject: webadmin: AbstractSubTabPanelPresenter code cleanup
......................................................................


webadmin: AbstractSubTabPanelPresenter code cleanup

The getMainTabRequest method isn't defined through an interface
and isn't overridden by subclasses. It's only called within the
AbstractSubTabPanelPresenter class itself.

Therefore, the condition part `getMainTabRequest() != null` will
always be false, and the code below will never execute.

Change-Id: I1f6211ac84d331f5d23b89be632cd934e0d60395
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractSubTabPanelPresenter.java
1 file changed, 0 insertions(+), 23 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Vojtech Szocs: Verified



-- 
To view, visit https://gerrit.ovirt.org/79912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1f6211ac84d331f5d23b89be632cd934e0d60395
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list