Change in ovirt-engine[master]: core: make sure the VM is ran with the correct rng device

Code Review gerrit at ovirt.org
Mon Jun 5 09:37:59 UTC 2017


>From Tomas Jelinek <tjelinek at redhat.com>:

Tomas Jelinek has submitted this change and it was merged.

Change subject: core: make sure the VM is ran with the correct rng device
......................................................................


core: make sure the VM is ran with the correct rng device

Two changes done:
- on run, make sure the correct rng source is used
- the RngUtils.validate() is changed to not to take the change in versions into
  account since if the snapshot without memory is restored, the compatibility
  does not change but the rng source does. In a followup patch also the unused
  effectiveVersion will be removed.

The specific bug fixed in this patch is that in version 4.0 the random source
was "/dev/random" while in 4.1 it was "/dev/urandom" so the rng source needs to
be reconfigured.

Change-Id: If232da469fa6db9a20ed62eb6298a7d0a53064d8
Bug-Url: https://bugzilla.redhat.com/1446640
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/RngDeviceUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/RngUtils.java
4 files changed, 40 insertions(+), 12 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Jenkins CI: Passed CI tests
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/77548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If232da469fa6db9a20ed62eb6298a7d0a53064d8
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list