Change in ovirt-engine[master]: webadmin: restrict port number in URL

Code Review gerrit at ovirt.org
Tue Jun 6 08:24:00 UTC 2017


>From Alona Kaplan <alkaplan at redhat.com>:

Alona Kaplan has submitted this change and it was merged.

Change subject: webadmin: restrict port number in URL
......................................................................


webadmin: restrict port number in URL

If an URL contains the optional port, the length of the port
number string has to be between 1 and 5 characters.

Change-Id: Ibe92d895d8f81d81dadf2145d258d1209f7f17bc
Signed-off-by: Dominik Holler <dholler at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1456233
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UriAuthority.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/UriAuthorityTest.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/UrlValidationTest.java
3 files changed, 17 insertions(+), 1 deletion(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Dominik Holler: Verified
  Alona Kaplan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/77517
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe92d895d8f81d81dadf2145d258d1209f7f17bc
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list