Change in ovirt-engine[master]: frontend: set DAD to false when entity is unavailable

Code Review gerrit at ovirt.org
Tue Jun 6 10:06:10 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: frontend: set DAD to false when entity is unavailable
......................................................................


frontend: set DAD to false when entity is unavailable

Patch a2e073845dc5485b36a6bad00c1a8e63c238342b indeed fixed a UI bug as
requested, but it also made it impossible to:
1. Navigate to new block storage domain window.
2. Set DAD to true.
3. Navigate to file domain and create one.

Since the last time DAD was available it was set to true, and since only
the availability of DAD is set to false, the value remains true and the
frontend tries to create a file domain with DAD = true ,which is
impossible, and the user gets an error message.

This patch sets DAD to false whenever it is unavailable.

Change-Id: I7dfaa3e5e8ab083d2c0e4f3409e24a1b5111487b
Bug-Url: https://bugzilla.redhat.com/1458568
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/77758
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7dfaa3e5e8ab083d2c0e4f3409e24a1b5111487b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list