Change in ovirt-engine[master]: backend: sync all luns when upgrading a data center

Code Review gerrit at ovirt.org
Thu Jun 8 12:14:40 UTC 2017


>From Daniel Erez <derez at redhat.com>:

Daniel Erez has submitted this change and it was merged.

Change subject: backend: sync all luns when upgrading a data center
......................................................................


backend: sync all luns when upgrading a data center

Up until now, when upgrading a data center from version <= 4.0 to
version >= 4.1, all the storage domains' luns were synchronized in order
to update their discard related new data from vdsm.
However, direct luns were never synchronized and updated, so their
discard related data was not automatically updated.
Now, also direct luns that are attached to a VM in the data center are
synchronized.

Also, since UpdateStoragePoolCommand now uses SyncAllUsedLunsCommand and
doesn't call directly to SyncLunsInfoForBlockStorageDomainCommand for
all n active block storage domain, synchronizing all their luns should
take ~ n times faster than it did before.

Change-Id: Id2f191a5f3580d7c73764b9dcd80fe8b4ed43b1e
Bug-Url:https://bugzilla.redhat.com/1455547
Bug-Url:https://bugzilla.redhat.com/1455548
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommandTest.java
2 files changed, 14 insertions(+), 106 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, but someone else must approve
  Allon Mureinik: Looks good to me, approved
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/77103
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2f191a5f3580d7c73764b9dcd80fe8b4ed43b1e
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list