Change in ovirt-engine[master]: core: minor cleanup in lun disks monitoring

Code Review gerrit at ovirt.org
Thu Jun 8 14:29:06 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: minor cleanup in lun disks monitoring
......................................................................


core: minor cleanup in lun disks monitoring

1. Use Collections.emptyMap instead of instantiating a map every
time, even if there are no lun disks connected to the VM.

2. Use early-return to simplify the code.

Change-Id: I9f5b3f386df87e03e3edfab5f1287707a0ca7242
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 21 insertions(+), 21 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Looks good to me, but someone else must approve
  Arik Hadas: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78008
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9f5b3f386df87e03e3edfab5f1287707a0ca7242
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list