Change in ovirt-engine[master]: webadmin: ListModelObjectCellTable ArrayList ctor

Code Review gerrit at ovirt.org
Sun Jun 11 15:30:32 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: ListModelObjectCellTable ArrayList ctor
......................................................................


webadmin: ListModelObjectCellTable ArrayList ctor

This patch creates an ArrayList from the getSelectedSet() by using
the overloaded consturctor instead of looping over getSelectedSet()
and calling List#add for each element.
At worst, this syntax is just cleaner and easier to understand. At
best, it may offer a slightly improved performance, as the ArrayList
has prior knowledge of the number of elements being added to it, and
can thus avoid resizes.

Change-Id: I0ab0b97006e95007e8495a7c017b563bcc148de8
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelObjectCellTable.java
1 file changed, 1 insertion(+), 4 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Greg Sheremeta: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ab0b97006e95007e8495a7c017b563bcc148de8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list