Change in ovirt-engine[ovirt-engine-4.1]: backend: fix log with empty removed luns list

Code Review gerrit at ovirt.org
Mon Jun 12 08:06:53 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: backend: fix log with empty removed luns list
......................................................................


backend: fix log with empty removed luns list

When SyncLunsInfoForBlockStorageDomain removes old luns from the db, it
logs "Removed LUNs, IDs '<luns_list>'".
When there are no luns to remove, the following useless log was still
printed: "Removed LUNs, IDs ''".

This patch fixes this bug so no log will be printed if there are no luns
to remove.

Change-Id: I072af233a3201980f69e73806fb068e6f1c39c1d
Bug-Url: https://bugzilla.redhat.com/1460512
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommandTest.java
2 files changed, 25 insertions(+), 10 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/78069
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I072af233a3201980f69e73806fb068e6f1c39c1d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list