Change in ovirt-engine[master]: core: avoid log flood on pause image upload

Code Review gerrit at ovirt.org
Mon Jun 12 13:05:04 UTC 2017


>From Daniel Erez <derez at redhat.com>:

Daniel Erez has submitted this change and it was merged.

Change subject: core: avoid log flood on pause image upload
......................................................................


core: avoid log flood on pause image upload

When pausing image upload, the upload command is left running
for supporting upload resume. I.e. the command is being constantly
polled by CoCo. To avoid a redundant operation and log [1] on each poll,
ensured 'stopImageTransferSession' method invocation only once.

[1] WARN org.ovirt.engine.core.bll.storage.disk.image.UploadDiskImageCommand
 Failed to stop image transfer session. Ticket does not exist for image ...

Change-Id: I28c8fff263278bc0ae6c6bd222685ca1a750fee6
Bug-Url: https://bugzilla.redhat.com/1402048
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommand.java
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Verified
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I28c8fff263278bc0ae6c6bd222685ca1a750fee6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list