Change in ovirt-engine[master]: webadmin: Moved bookmarks to header icon

Code Review gerrit at ovirt.org
Thu Jun 15 15:43:01 UTC 2017


>From Alexander Wels <awels at redhat.com>:

Alexander Wels has submitted this change and it was merged.

Change subject: webadmin: Moved bookmarks to header icon
......................................................................


webadmin: Moved bookmarks to header icon

- I had assumed bookmarks were by user and thus put it
  under the user menu. However bookmarks are global thus
  it required its own icon. This patch moves bookmarks to
  its own icon.
- Re-arranged the order of the icons to match UXD design.

Change-Id: I18f714555ee1e84a14c9fdc61ced6c9bedef11bd
Signed-off-by: Alexander Wels <awels at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.ui.xml
2 files changed, 27 insertions(+), 20 deletions(-)

Approvals:
  Alexander Wels: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/77691
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I18f714555ee1e84a14c9fdc61ced6c9bedef11bd
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list