Change in ovirt-engine[master]: core: Fix logging

Code Review gerrit at ovirt.org
Thu Jun 15 18:32:04 UTC 2017


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: core: Fix logging
......................................................................


core: Fix logging

Logging messages should not use new-line characters, because it breaks
parsing of logs. ToStringBuilder already contains append(Collection)
method, which prints nicely content of collection, so no need to use
some other formatters.

Change-Id: If0ebf0bea4d2726ec3763a530ec48c35573d50ff
Signed-off-by: Martin Perina <mperina at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostSetupNetworksVdsCommandParameters.java
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Martin Peřina: Verified
  Martin Mucha: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78137
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If0ebf0bea4d2726ec3763a530ec48c35573d50ff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list