Change in ovirt-engine[master]: webadmin: EnumRadioEditor inverted condition

Code Review gerrit at ovirt.org
Thu Jun 15 19:50:39 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: EnumRadioEditor inverted condition
......................................................................


webadmin: EnumRadioEditor inverted condition

Instead of having an if condition that does nothing and putting all
the logic in the else block, the condition can just be inverted in
order to make the code cleaner and easier to read.

Change-Id: I014f2ffc6996527c44e2c3a48e4a836e96fe7c6b
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnumRadioEditor.java
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78155
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I014f2ffc6996527c44e2c3a48e4a836e96fe7c6b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list