Change in ovirt-engine[master]: webadmin: simplify EnumRadioEditor#isEnabled

Code Review gerrit at ovirt.org
Thu Jun 15 19:50:39 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: simplify EnumRadioEditor#isEnabled
......................................................................


webadmin: simplify EnumRadioEditor#isEnabled

isEnabled(E) would return true regardless of the argument passed to
it, and is never overriden.

isEnabled() just iterates over the visible items and returns true if
any isEnabled(item) returns true - which they all do.

This logic can thus be dramatically simplified to just return true if
there are any visible items.

Change-Id: If716d99a55aeb9d6889c8e39525d7e22f0c9ff89
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnumRadioEditor.java
1 file changed, 1 insertion(+), 13 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78152
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If716d99a55aeb9d6889c8e39525d7e22f0c9ff89
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list