Change in ovirt-engine[master]: packaging: license: add NOTICE file

Code Review gerrit at ovirt.org
Thu Jun 22 07:31:41 UTC 2017


>From Sandro Bonazzola <sbonazzo at redhat.com>:

Sandro Bonazzola has submitted this change and it was merged.

Change subject: packaging: license: add NOTICE file
......................................................................


packaging: license: add NOTICE file

Most Apache License 2.0 projects don't have a NOTICE file, but ASF
proejects always do. So whenever you are using code from an ASF
project you have to make sure you copy over that project's NOTICE
file.

In ovirt-engine, it looks like the files in
utils/src/main/java/org/ovirt/engine/core/utils/ssl were taken from
the old Apache HttpClient project. The NOTICE file for one revision of
this project is here:
https://svn.apache.org/repos/asf/httpcomponents/oac.hc3x/trunk/NOTICE.txt

Another use of ASF code I found was:
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java

which seems to be taken from an old version of Apache Commons Lang,
which had a NOTICE file approximately like this one:
https://git-wip-us.apache.org/repos/asf?p=commons-lang.git;a=blob;f=NOTICE.txt;hb=5aa9532c4e7d346b6555f38e48a83b5858936a83

Adding the NOTICE to the project.

Change-Id: I640c5d46cb3d78cf9f95c789e3956633ac8c5741
Signed-off-by: Sandro Bonazzola <sbonazzo at redhat.com>
---
A NOTICE
1 file changed, 14 insertions(+), 0 deletions(-)

Approvals:
  Sandro Bonazzola: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/78371
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I640c5d46cb3d78cf9f95c789e3956633ac8c5741
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde at redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael at rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list