Change in ovirt-log-collector[master]: CollectorBase: fix list index out of range

Code Review gerrit at ovirt.org
Thu Jun 22 16:18:03 UTC 2017


>From Douglas Schilling Landgraf <dougsland at redhat.com>:

Douglas Schilling Landgraf has submitted this change and it was merged.

Change subject: CollectorBase: fix list index out of range
......................................................................


CollectorBase: fix list index out of range

Re-ordered tests on an list avoiding an index out
of range exception if the sosreport filename is not
in the output of sosreport call.

The IndexError was used to detect an error in sosreport call
instead of properly handling a parsing error. Added exception
handling for this cases and made it a critical error since
this means the underlying sosreport is having troubles.

Change-Id: I40235242bf4eabd4b1cd9599eb45cb124e182df3
Bug-Url: https://bugzilla.redhat.com/1460734
Signed-off-by: Sandro Bonazzola <sbonazzo at redhat.com>
---
M src/__main__.py
1 file changed, 18 insertions(+), 12 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Looks good to me, approved
  Sandro Bonazzola: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/78534
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I40235242bf4eabd4b1cd9599eb45cb124e182df3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde at redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael at rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list