Change in ovirt-engine[master]: core: Allow to migrate a paused VM with Post-copy policy

[Code Review]

>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: Allow to migrate a paused VM with Post-copy policy
......................................................................


core: Allow to migrate a paused VM with Post-copy policy

Libvirt does not allow to migrate a VM in Paused state with post-copy
migration. If migration policy of a cluster contains a "postcopy"
action, every attempt to migrate a paused VM fails because libvirt
returns an error, not allowing migration to start. On the other side,
the current Post-copy migration policy uses post-copy only as last
resort, when a regular migration stalls. It is unlikely that migration
will be stalling when migrating a paused VM, so it is safe to use a
Post-copy policy with it.

Libvirt bug have been open for this issue:
https://bugzilla.redhat.com/show_bug.cgi?id=1464792

This patch introduces a workaround: MigrateVmCommand will filter a
"postcopy" action out of the effective migration policy, if the VM is in
Paused state. This helps to avoid libvirt error and allows to migrate
such a VM in a cluster with Post-copy migration policy.

Change-Id: I5fcaf057f3d3443d5d0dd30e542a8e159acc5bd4
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 23 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5fcaf057f3d3443d5d0dd30e542a8e159acc5bd4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>