Change in ovirt-engine[master]: core: fixing FenceAgent toString

Code Review gerrit at ovirt.org
Tue Jun 27 07:51:00 UTC 2017


>From Eli Mesika <emesika at redhat.com>:

Eli Mesika has submitted this change and it was merged.

Change subject: core: fixing FenceAgent toString
......................................................................


core: fixing FenceAgent toString

core: fixing FenceAgent toString to display options correctly

The protocol between engine and VDSM requires that the separator between
fence agent options will be a NEWLINE. However we are implementing the
toString method that is using the logger to write log messages, we
should replace the NEWLINE with COMMA.

Change-Id: Ic117ee404fb909515d5a3d18c6e2c1ba8fa1a9b0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1457814
Signed-off-by: emesika <emesika at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/FenceAgent.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Eli Mesika: Verified
  Ravi Nori: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/78621
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic117ee404fb909515d5a3d18c6e2c1ba8fa1a9b0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list